RFR: 8339918: Remove checks for outdated -t -tm -Xfuture -checksource -cs -noasyncgc options from the launcher [v5]

[David Holmes]

On Mon, 16 Sep 2024 03:56:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this change which cleans up the `java` launcher to remove checks/support for outdated options?
>> 
>> As noted in https://bugs.openjdk.org/browse/JDK-8339918, these 6 options have been outdated and unsupported for several releases now. 2 of them even throw an error currently. The change in this PR removes the code which had specific checks for these options and will now consider these options just like any other unknown option to the launcher.
>> 
>> tier1, tier2 and tier3 testing passed with these changes. Higher tier testing is in progress.
>> 
>> Would this change require a CSR?
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove -noasyncgc from com.sun.tools.example.debug.tty.TTY

Looks good. But another cleanup is also possible

src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java line 991:

> 989:                    // Old-style options (These should remain in place as long as
> 990:                    //  the standard VM accepts them)
> 991:                    token.equals("-prof") ||

The `-prof` flag doesn't exist either.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20945#pullrequestreview-2305716139
PR Review Comment: https://git.openjdk.org/jdk/pull/20945#discussion_r1760502796