RFR: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow [v3]
Jaikiran Pai
jpai at openjdk.org
Mon Sep 16 06:52:40 UTC 2024
On Mon, 16 Sep 2024 01:17:21 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix code comment style where appropriate
>
> src/java.base/share/native/libjli/java.c line 1421:
>
>> 1419: ) {
>> 1420:
>> 1421: // command line specified "-splash:" takes priority over manifest one.
>
> General comment on comment style. Comments should either be written like sentences and start with a Capital and end with a period; or have neither.
I have now updated this PR to follow this suggestion for the new/updated code comments that were introduced in this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20997#discussion_r1760613901
More information about the core-libs-dev
mailing list