RFR: 8340114: Remove outdated SelectVersion() function from the launcher and update the code comments explaining the code flow [v6]
Jaikiran Pai
jpai at openjdk.org
Mon Sep 16 14:05:06 UTC 2024
On Mon, 16 Sep 2024 13:50:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> For macosx, the CreateExecutionEnvironment unconditionally, through an internal MacOSXStartup function, spawns a new thread (pthread_create).
I forgot to note that, the reason for spawning this new thread is explained as a code comment (unrelated to the changes in this PR) on the `MacOSXStartup` function and it says:
/*
* Mac OS X mandates that the GUI event loop run on very first thread of
* an application. This requires that we re-call Java's main() on a new
* thread, reserving the 'main' thread for Cocoa.
*/
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20997#discussion_r1761227352
More information about the core-libs-dev
mailing list