RFR: 8338546: Speed up ConstantPoolBuilder::classEntry(ClassDesc) [v4]
Claes Redestad
redestad at openjdk.org
Thu Sep 19 18:35:44 UTC 2024
On Thu, 19 Sep 2024 18:02:07 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Speed up `ConstantPoolBuilder::classEntry(ClassDesc)` by going through `ClassDesc` comparison and reusing descriptor hash to calculate internal name hash if possible. No suitable device to run benchmarks so need to find something to run the new benchmark to ensure things work as intended.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>
> - Fresh creation bench
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - Fix build
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - Buggy 2nd attempt - crashes hotspot
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - More conflicts
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - Merge branch 'master' of https://github.com/openjdk/jdk into feature/classentry-speedup
> - ... and 7 more: https://git.openjdk.org/jdk/compare/3bb8de31...eed09345
LGTM
-------------
Marked as reviewed by redestad (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20667#pullrequestreview-2316420990
More information about the core-libs-dev
mailing list