RFR: 8338017: Add AOT command-line flag aliases [v3]

David Holmes dholmes at openjdk.org
Fri Sep 20 01:19:40 UTC 2024


On Thu, 19 Sep 2024 22:06:14 GMT, Mat Carter <macarte at openjdk.org> wrote:

>> src/hotspot/share/runtime/flags/jvmFlagConstraintsRuntime.cpp line 40:
>> 
>>> 38:       strcmp(value, "create") != 0 &&
>>> 39:       strcmp(value, "auto") != 0 &&
>>> 40:       strcmp(value, "on")) {
>> 
>> This should be strcmp(value, "on") != 0 ??
>
> Okay both ways are valid, you could also remove the other "!= 0", the mixing was confusing

Hotspot style rule is "no implicit booleans" so the check for `!= 0` should be used in all cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1767795254


More information about the core-libs-dev mailing list