RFR: 8340544: Optimize setLocalsFromArg

[Claes Redestad]

On Fri, 20 Sep 2024 09:18:32 GMT, Shaojin Wen <swen at openjdk.org> wrote:

> CheckLocal once, reduce redundant checkLocal, rewrite switch, reduce method size, codeSize is reduced from 367 to 263.

LGTM

src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java line 1069:

> 1067:                     localsSize += 2;
> 1068:                 } else {
> 1069:                     if (desc == CD_int || desc == CD_boolean || desc == CD_byte || desc == CD_char || desc == CD_short) {

An alternative would be `if (!desc.isPrimitive()) { .. } else if (desc == CD_float) { .. } else { /* INTEGER_TYPE */ }` - might be more compact at least.

-------------

Marked as reviewed by redestad (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21106#pullrequestreview-2318716350
PR Review Comment: https://git.openjdk.org/jdk/pull/21106#discussion_r1768877913