RFR: 8336025: Improve ZipOutputSream validation of MAX CEN Header field limits [v3]
Alan Bateman
alanb at openjdk.org
Fri Sep 20 18:00:36 UTC 2024
On Fri, 20 Sep 2024 15:54:12 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Please review the following PR which addresses that ZipOutputStream should validate the CEN header fields similar to what was done via [JDK-8316141](https://bugs.openjdk.org/browse/JDK-8316141)
>>
>> As part of this change, the javadoc for ZipEntry has been updated to indicate that the CEN Header(46 bytes) + entry name length + comment length + extra data length must not exceed 0xfffff.
>>
>> Mach5 tiers 1-3 runs were clean. The zip and jar JCK tests also continue to pass
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated javadoc based on last round of input
Latest updates to the API docs looks okay. I didn't do a detailed review of the test updates.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21003#pullrequestreview-2318920557
More information about the core-libs-dev
mailing list