RFR: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time [v2]

Calvin Cheung ccheung at openjdk.org
Fri Sep 20 18:03:52 UTC 2024


> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS archive;
> during run time, full module graph will not be used.
> 
> With this patch, the full module graph will be included in the CDS archive with the `--module-path` option. During run time, if the same `--module-path` option is specified, the archived module graph will be used.
> 
> The checking of module paths between dump time and run time is more lenient compared with the checking of class paths; the ordering of the modules is unimportant, duplicate module names are ignored.
> E.g. the following is considered a match:
> dump time      runtime
> m1,m2             m2,m1
> m1,m2             m1,m2,m2
> 
> I included some [notes](https://bugs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275) in the bug report regarding some changes in the corelib classes.

Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:

  comments from David, Alan, and Ioi

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21048/files
  - new: https://git.openjdk.org/jdk/pull/21048/files/33c9d247..c6fc5bd8

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21048&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21048&range=00-01

  Stats: 138 lines in 12 files changed: 86 ins; 37 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/21048.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21048/head:pull/21048

PR: https://git.openjdk.org/jdk/pull/21048


More information about the core-libs-dev mailing list