RFR: 8336895: BufferedReader doesn't read full \r\n line ending when it doesn't fit in buffer [v4]

Alan Bateman alanb at openjdk.org
Sat Sep 21 15:03:40 UTC 2024


On Wed, 28 Aug 2024 18:04:33 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add some verbiage stating that two buffered readers or input streams should not be used to read from the same reader or input stream, respectively.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8336895: "  Doing" -> " Doing" and add some {@code} tags

src/java.base/share/classes/java/io/BufferedInputStream.java line 58:

> 56:  * incorrect result since each instance of {@code BufferedInputStream}
> 57:  * maintains its own state.
> 58:  *

It might be clearer to just say that once wrapped with a BIS, the underlying input stream should not be used directly or wrapped with another stream. This is potentially something for an apiNote as it's more about API usage,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20320#discussion_r1769589981


More information about the core-libs-dev mailing list