RFR: 8337279: Optimize format instant [v7]

Shaojin Wen swen at openjdk.org
Mon Sep 23 05:37:17 UTC 2024


On Tue, 3 Sep 2024 17:32:43 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> I don't think using SharedSecret just for performance improvement and code size reduction is the right way, as the class is the last resort as the header says:
> 
> ```
>  * <p><strong>
>  * Usage of these APIs often means bad encapsulation designs,
>  * increased complexity and lack of sustainability.
>  * Use this only as a last resort!
>  * </strong>
> ```

If SharedSecret is not recommended, do you recommend extracting these methods to jdk.internal?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20353#issuecomment-2367270116


More information about the core-libs-dev mailing list