RFR: 8338694: x86_64 intrinsic for tanh using libm [v12]

Srinivas Vamsi Parasa duke at openjdk.org
Mon Sep 23 19:24:51 UTC 2024


On Mon, 23 Sep 2024 19:14:10 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Looks good. I have only one nitpick. I will start testing.

Thank you Vladimir!

> src/hotspot/share/c1/c1_Compiler.cpp line 170:
> 
>> 168:   case vmIntrinsics::_dcos:
>> 169:   case vmIntrinsics::_dtan:
>> 170:   #if defined(X86)
> 
> Use `#ifdef AMD64` for x64 only

Thanks Vladimir! Please see the code updated with `#ifdef AMD64`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20657#issuecomment-2369168165
PR Review Comment: https://git.openjdk.org/jdk/pull/20657#discussion_r1771961469


More information about the core-libs-dev mailing list