RFR: 8339260: Move rarely used constants out of ClassFile [v7]

Chen Liang liach at openjdk.org
Mon Sep 23 21:42:11 UTC 2024


> Many constants are cluttered in `ClassFile`. However, only a few of them are ever used by regular users, most notably `ACC_` flags and `JAVA_X_VERSION` constants. All other constants are specific and should live in more local locations, such as getters that return these constants.
> 
> This simplification of `ClassFile` constants improves user onramp to the Class-File API.
> 
> Notably, before, if `ClassFile` is static imported, `Opcode` enums must be qualified due to name clashes; this relocation allows `Opcode` enums to be static imported with `ACC_` flags, improving class file writing user experience.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:

 - Move raw opcodes to impl only
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
   
   # Conflicts:
   #	src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java
   #	src/java.base/share/classes/jdk/internal/classfile/impl/SplitConstantPool.java
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - omission in tests
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - Rename constants at new locations, link to related factories, cp tag constant names
 - Fix compile errors
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - Merge branch 'master' of https://github.com/openjdk/jdk into fix/constant-moving
 - ... and 6 more: https://git.openjdk.org/jdk/compare/e97f0fe1...8b03ad17

-------------

Changes: https://git.openjdk.org/jdk/pull/20773/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20773&range=06
  Stats: 2445 lines in 37 files changed: 537 ins; 908 del; 1000 mod
  Patch: https://git.openjdk.org/jdk/pull/20773.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20773/head:pull/20773

PR: https://git.openjdk.org/jdk/pull/20773


More information about the core-libs-dev mailing list