RFR: 8338017: Add AOT command-line flag aliases [v5]

[David Holmes]

On Mon, 23 Sep 2024 17:33:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>> 
>> Add the following command-line options as specified in JEP 483:
>> 
>> 
>> - `-XX:AOTMode=off/record/create/auto/on`
>> - `-XX:AOTConfiguration=<file>.aotconfig`
>> - `-XX:AOTCache=<file>.aot`
>> 
>> These options are implemented as aliases to existing command-line flags such as `-Xshare:dump`, `-XX:SharedArchiveFile`, `-XX:DumpLoadedClassesList`, etc.
>> 
>> Please see the CSR (TODO) for detailed specification.
>> 
>> -----
>> See [here](https://bugs.openjdk.org/browse/JDK-8315737) for the sequence of dependent RFEs for implementing JEP 483.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @macarte comments

Marked as reviewed by dholmes (Reviewer).

src/hotspot/share/cds/metaspaceShared.cpp line 677:

> 675:     // When the new -XX:AOTMode=create flag is used, we can't return
> 676:     // to the JLI launcher, as the launcher will fail when trying to
> 677:     // run the main class, which is not what we want.

I actually find the original more clear - we have a new flag that we check and act upon. The "!old flag" seems an awkward way of saying "new flag".

-------------

PR Review: https://git.openjdk.org/jdk/pull/20516#pullrequestreview-2324067454
PR Review Comment: https://git.openjdk.org/jdk/pull/20516#discussion_r1772620807