RFR: 8340717: Remove unused function declarations from java.c/java.h of the launcher
Alan Bateman
alanb at openjdk.org
Tue Sep 24 07:02:38 UTC 2024
On Tue, 24 Sep 2024 04:33:14 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this cleanup to the launcher code to remove declarations of unused functions?
>
> The `ValidateModules` function appears to be a left-over from https://bugs.openjdk.org/browse/JDK-8194937.
>
> The `SetApplicationClassPath` and `PrintMachineDependentOptions` appear to have been unused for a long time (ever since the first commit in the current JDK repo).
>
> The data model related macros, being removed in this PR, are unused and no longer relevant.
>
> No new tests have been added and existing tier1, tier2 and tier3 tests continue to pass with this change.
Marked as reviewed by alanb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21149#pullrequestreview-2324252827
More information about the core-libs-dev
mailing list