RFR: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage

Lance Andersen lancea at openjdk.org
Tue Sep 24 19:41:35 UTC 2024


On Mon, 23 Sep 2024 18:05:31 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this PR which adds test coverage for the case of reading from an input stream obtained using`ZipFile:getInputStream` after the backing `ZipFile` has been closed. 
> 
> The unspecified but long-standing behavior for this unusual use case is to throw `IOException`, but this is not verified by current tests. Adding a test would help prevent regressions in this area.
> 
> The test is parameterized to excercise a variation of stored/deflated entries, and a variation of read behaviors before the `ZipFile` is closed.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21142#pullrequestreview-2326279159


More information about the core-libs-dev mailing list