RFR: 8340885: Desugar ZipCoder.Comparison [v2]

Claes Redestad redestad at openjdk.org
Wed Sep 25 10:12:50 UTC 2024


On Wed, 25 Sep 2024 09:52:20 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Shift constant values
>>  - Update src/java.base/share/classes/java/util/zip/ZipCoder.java
>>    
>>    Co-authored-by: Eirik Bjorsnos <eirbjo at gmail.com>
>
> src/java.base/share/classes/java/util/zip/ZipCoder.java line 69:
> 
>> 67:          * to the encoded string.
>> 68:          */
>> 69:         EXACT_MATCH = 1,
> 
> Would there be any (positive) performance implications of starting these at zero?

It saves a byte since there are bytecode constants for `0`-`2` but not for `3` :-) Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21176#discussion_r1774954413


More information about the core-libs-dev mailing list