RFR: 8340885: Desugar ZipCoder.Comparison [v2]

[Claes Redestad]

On Wed, 25 Sep 2024 09:53:39 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Claes Redestad has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Shift constant values
>>  - Update src/java.base/share/classes/java/util/zip/ZipCoder.java
>>    
>>    Co-authored-by: Eirik Bjorsnos <eirbjo at gmail.com>
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1872:
> 
>> 1870:                     // Compare the lookup name with the name encoded in the CEN
>> 1871:                     switch (zc.compare(name, cen, noff, nlen, addSlash)) {
>> 1872:                         case ZipCoder.EXACT_MATCH:
> 
> This would perhaps read cleaner with a static import of the constants?

No strong feeling about this, but I lean towards not using static imports unless there's repeated use.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21176#discussion_r1774960752