RFR: 8339711: ZipFile.Source.initCEN needlessly reads END header

[Eirik Bjørsnøs]

On Wed, 25 Sep 2024 15:03:57 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> @eirbjo: an alternative suggested offline by @LanceAndersen is that we merge the two PRs, since they intermingle a bit too much and have the same goal of optimizing initCEN. OK if I merge this into #21133?

My first thought was "that also works fine", but then:

I actually see these two PRs as having separate and unrelated goals. One is a performance optimization targeting better / earlier JIT compiled code, the other is performance neutral and simply aims to make the code easier to understand and maintain.

While mixing these together might simplify the review work done here, I think any future maintainer would prefer if they could study these changes independently. To maintain a clean change history, I'd prefer if we could review and integrate them as independent PRs.

The review order of the PRs feels less important for me.  It's fine for me to hold this off and wait for your changes, as you say this one is pretty trivial and easy for me to  merge or redo after your PR is integrated. If this PR is deemed easy to review, then perhaps it's better to get it integrated first.

But if you don't agree, that's also fine! I'll concede and withdraw this PR, no worries.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20905#issuecomment-2374519289