RFR: 8242888: Convert dynamic proxy to hidden classes [v2]

Chen Liang liach at openjdk.org
Wed Sep 25 17:03:18 UTC 2024


On Mon, 27 May 2024 00:04:07 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Flip flags, hidden is enabled only by choice
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/hidden-proxy
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/hidden-proxy
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java
>>  - Missing changes to commit
>>  - Condense legacy and modern impl
>>  - Clean up
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/hidden-proxy
>>  - Cleanup...
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into feature/hidden-proxy
>>    
>>    # Conflicts:
>>    #	src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java
>>  - Fixes
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/fb703258...16906bfb
>
> src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line 624:
> 
>> 622:             "true".equals(props.getProperty("jdk.disableSerialConstructorChecks"));
>> 623: 
>> 624:         useLegacyProxyImpl &= !useOldSerializableConstructor;
> 
> Suggestion:
> 
>         useLegacyProxyImpl |= useOldSerializableConstructor;

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19356#discussion_r1631392934


More information about the core-libs-dev mailing list