RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image

[Chen Liang]

On Thu, 26 Sep 2024 01:36:31 GMT, Henry Jen <henryjen at openjdk.org> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java line 1248:
>> 
>>> 1246:                             methodName,
>>> 1247:                             MethodTypeDesc.of(CD_EXPORTS.arrayType()),
>>> 1248:                             ACC_PRIVATE | ACC_FINAL | ACC_STATIC,
>> 
>> Just curious, why do we mark our split provider methods final? The final flag is only used for hiding.
>
> Thanks for pointing that out, I just follow language convention and did not think of that.

In language convention, I don't think we declare our private static utility methods as final either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21022#discussion_r1776180846