RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v5]

[fabioromano1]

On Tue, 3 Sep 2024 16:50:26 GMT, fabioromano1 <duke at openjdk.org> wrote:

>>> > It would be nice to see some benchmarks where it gives performance benefits.
>>> 
>>> @kuksenko Try to run the benchmark of the `BigInteger`'s square root, maybe there the benefits are more visible...
>> 
>> "maybe"????
>> So, you don't have proof that this PR gives any performance benefits.
>> I don't think we have to make an optimization for the sake of optimizations.
>
> @kuksenko It's not only for the sake of optimization, but to make the code more clear and consistent with the implementation of `BigInteger.shiftLeft()`.

> @fabioromano1 Do you plan to work for more systematic tests, as discussed [above](https://github.com/openjdk/jdk/pull/20008#discussion_r1756784216)?

@rgiulietti Surely they would be useful, but I think it's reasonable to retain that the code is already correct, since it has been revised and it is based on solid logic.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20008#issuecomment-2379435774