RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v11]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Sep 27 15:25:39 UTC 2024


On Thu, 12 Sep 2024 20:49:49 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> This implementation of MutableBigInteger.leftShift(int) optimizes the current version, avoiding unnecessary copy of the MutableBigInteger's value content and performing the primitive shifting only in the original portion of the value array rather than in the value yet extended with trailing zeros.
>
> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Keep parameters' name consistence

The tests must all pass before the code is integrated. Thus, the main purpose of retaining them in the repo is not to check the _current_ code, but to detect possible regressions when evolving it in the future.

Before having a final review, could you please merge `master` branch into yours?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20008#issuecomment-2379536067


More information about the core-libs-dev mailing list