RFR: 8334714: Implement JEP 484: Class-File API [v6]
ExE Boss
duke at openjdk.org
Fri Sep 27 16:32:46 UTC 2024
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>
> - Updated copyright years
> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>
> # Conflicts:
> # src/java.base/share/classes/java/lang/classfile/Opcode.java
> # src/java.base/share/classes/java/lang/classfile/TypeAnnotation.java
> # src/java.base/share/classes/java/lang/classfile/attribute/StackMapFrameInfo.java
> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>
> # Conflicts:
> # src/java.base/share/classes/java/lang/classfile/Annotation.java
> # src/java.base/share/classes/java/lang/classfile/AnnotationValue.java
> # src/java.base/share/classes/java/lang/classfile/FieldModel.java
> # src/java.base/share/classes/java/lang/classfile/MethodModel.java
> # src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableInfo.java
> # src/java.base/share/classes/java/lang/classfile/attribute/RecordComponentInfo.java
> # src/java.base/share/classes/java/lang/classfile/instruction/LocalVariable.java
> - Merge branch 'master' into JDK-8334714-final
>
> # Conflicts:
> # src/java.base/share/classes/java/lang/classfile/CodeBuilder.java
> # src/java.base/share/classes/java/lang/classfile/Opcode.java
> # src/java.base/share/classes/java/lang/classfile/TypeKind.java
> - Merge remote-tracking branch 'openjdk/master' into JDK-8334714-final
>
> # Conflicts:
> # src/java.base/share/classes/java/lang/classfile/Annotation.java
> # src/java.base/share/classes/java/lang/classfile/AnnotationValue.java
> # src/java.base/share/classes/java/lang/classfile/AttributeMapper.java
> # src/java.base/share/classes/java/lang/classfile/TypeAnnotation.java
> # src/java.base/share/classes/java/lang/classfile/constantpool/PoolEntry.java
> # src/jdk.javadoc/share/classes/jdk/javadoc/internal/html/HtmlId.java
> - Merge branch 'master' into JDK-8334714-final
> - bumped @since tag
> - 8334714: Class-File API leaves preview
I wish that the concrete `PoolEntry` subtypes had `of(…)` factory methods which would create instances using the `TemporaryConstantPool`, as I find it necessary to create `PoolEntry` instances in contexts where a `ConstantPoolBuilder` is not easily available (and `ConstantPoolBuilder.of()` is relatively expensive when creating a one‑off `PoolEntry` instance) and the current `TemporaryConstantPool` implementation doesn’t support all the creation methods.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19826#issuecomment-2379656905
More information about the core-libs-dev
mailing list