RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4]

Henry Jen henryjen at openjdk.org
Mon Sep 30 15:11:39 UTC 2024


On Mon, 30 Sep 2024 11:23:33 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review feedbacks
>
> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 587:
> 
>> 585:                             break;
>> 586:                         case 'k':
>> 587:                             kflag = true;
> 
> I am wondering if a warning should be displayed if this options is specified with any option other than 'x'

I considered that, but didn't implement it after confirmed other similar options didn't display any warning.
I do think it make sense to show a warning when using an option not valid in specific mode.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21141#discussion_r1781320078


More information about the core-libs-dev mailing list