RFR: 8340229: Improve opening sentence of FileInputStream constructor specification

Brian Burkhalter bpb at openjdk.org
Mon Sep 30 23:11:41 UTC 2024


On Sun, 29 Sep 2024 07:00:49 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Improve the first sentences of the three `FileInputStream` constructors, in particular removing the term "connection."
>
> src/java.base/share/classes/java/io/FileInputStream.java line 166:
> 
>> 164:     /**
>> 165:      * Creates a {@code FileInputStream} to read from an existing file
>> 166:      * represented by the {@code FileDescriptor} object {@code fdObj}.
> 
> I don't know if you meant to touch this constructor or not but I think it's okay to use "connected" here as this is creating a FIS to read bytes from whatever the file descriptor is connected to.

I have reverted it locally and that will be in the next commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21223#discussion_r1781881827


More information about the core-libs-dev mailing list