RFR: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output" [v4]
Jaikiran Pai
jpai at openjdk.org
Tue Apr 1 01:06:21 UTC 2025
On Mon, 31 Mar 2025 19:41:29 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>> test/jdk/java/lang/ref/FinalizerHistogramTest.java line 131:
>>
>>> 129: volatile boolean ref1Cleared = false;
>>> 130: volatile boolean ref2Cleared = false;
>>> 131: Thread thread;
>>
>> Nit: This need not be a field in the class and instead can be local to the constructor where the Thread is started. But it's OK to leave it like this if you prefer to.
>
> I feel better about maintaining a strong reference (`refQForTwo -> thread`) to the `Thread`.
Hello Brent, that's fine with me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24143#discussion_r2021968242
More information about the core-libs-dev
mailing list