RFR: 8352709: Remove bad timing annotations from WhileOpTest.java

[Jaikiran Pai]

On Mon, 24 Mar 2025 12:17:22 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> WhileOpTest.java is a TestNG test (`TestNG.dirs` is set in Find file: `test/jdk/java/util/stream/test/TEST.properties`)
> 
> As such, the `@run main/timeout=240` annotation is ignored. If that was not the case, it would complain about not specifying a main class.

The change looks good to me.

test/jdk/java/util/stream/test/org/openjdk/tests/java/util/stream/WhileOpTest.java line 50:

> 48:  * @test
> 49:  * @bug 8071597 8193856
> 50:  * @run main/timeout=240

The original change which introduced this `main/timeout` appears to be https://bugs.openjdk.org/browse/JDK-8134459. Going through the RFR of that change https://mail.openjdk.org/pipermail/core-libs-dev/2018-January/050878.html it appears that in addition to this timeout being introduced there was an additional change done to help improve the duration of this test. Plus there's also a comment in that JBS issue that the timeout hadn't been observed for a while (except locally).

I think all that explains why this test hasn't been timing out in the presence of this no-op directive.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24193#pullrequestreview-2731184354
PR Review Comment: https://git.openjdk.org/jdk/pull/24193#discussion_r2022189487