RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v6]
Jaikiran Pai
jpai at openjdk.org
Tue Apr 1 07:22:48 UTC 2025
On Mon, 31 Mar 2025 14:49:12 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>>
>> - Lance's inputs
>> - merge latest from master branch
>> - merge latest from master branch
>> - merge latest from master branch
>> - additional updates to the doc
>> - merge latest from master branch
>> - change "@implSpec" to "@apiNote" and update their text
>> - add class level documentation
>> - merge latest from master branch
>> - add tests
>> - ... and 2 more: https://git.openjdk.org/jdk/compare/690c3b58...ed7cf59e
>
> src/java.base/share/classes/java/util/zip/InflaterOutputStream.java line 123:
>
>> 121: * {@linkplain #close() Closing} this output stream
>> 122: * {@linkplain ##decompressor-usage will not close} the given
>> 123: * {@linkplain Inflater decompressor}.
>
> This can be normative too.
Thank you Alan for those inputs. I've updated the PR to make this normative in all the 4 class' constructors.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23655#discussion_r2022288963
More information about the core-libs-dev
mailing list