RFR: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate [v3]

Justin Lu jlu at openjdk.org
Wed Apr 2 19:46:13 UTC 2025


On Wed, 2 Apr 2025 10:05:04 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address further comments
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 562:
> 
>> 560:     /**
>> 561:      * Parses a {@code Number} from the input text, the subtype of which is always
>> 562:      * {@code Double}. The value returned is the {@code limit} corresponding
> 
> I wonder if we could improve the first sentence, e.g. "Parses the input text from the parse position as a Double" ?

Right, I think we can make the sub-type wording simplification and should mention `ParsePosition`'s role in the method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24361#discussion_r2025480425


More information about the core-libs-dev mailing list