RFR: 8353679: Restructure classes in jdk.jpackage.internal package

Alexander Matveev almatvee at openjdk.org
Fri Apr 4 03:14:52 UTC 2025


On Tue, 1 Apr 2025 15:18:13 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> - Move ConfigException, PackagerException, MsiVersion, and DottedVersion classes from "jdk.jpackage.internal" package to "jdk.jpackage.internal.model" package.
>  - Remove public ctor from DottedVersion class. It can only be constructed with `DottedVersion.lazy()` and `DottedVersion.greedy()` functions.
>  - Move PathGroup class from "jdk.jpackage.internal" package to "jdk.jpackage.internal.util" package.
>  - Move internal "MacHelper.PListWrapper" class into "jdk.jpackage.internal.util.PListReader". Add unit tests.
>  - Move internal "jdk.jpackage.internal.I18N.MultiResourceBundle" class into "jdk.jpackage.internal.util.MultiResourceBundle"
>  - Remove dead code from "src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties"
>  - Make PlatformVersionTest fail if reflection fails to locate expected version class.

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24358#pullrequestreview-2741667340


More information about the core-libs-dev mailing list