RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v3]
KIRIYAMA Takuya
duke at openjdk.org
Fri Apr 4 10:33:00 UTC 2025
On Tue, 25 Mar 2025 18:39:22 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> I see. This test only takes a very short time, but shouldn't the cases be added?
>
> Still no, starting a new Java runtime isn't that quick, and it brings no additional value.
> All tests are run 10's of thousands of times in every release, adding a few seconds here and there add up.
Thank you for the additional comment!
I understand that two test cases are sufficient as a general test for loggers.
However, the valid level of "System.exit and Runtime.exit debug logging" is determined by the following specific implementation:
https://github.com/openjdk/jdk/blob/41d4a0d7bdda2a96af1e7f549c05d99d68c040dc/src/java.base/share/classes/java/lang/Shutdown.java#L175
Does this code need to be tested exhaustively?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24050#discussion_r2028556413
More information about the core-libs-dev
mailing list