RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v3]
Christoph Langer
clanger at openjdk.org
Mon Apr 7 12:16:56 UTC 2025
On Mon, 7 Apr 2025 12:11:51 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the installed JDK image when a user creates a custom run-time from it. This is problematic for example for files that often come from a different package (e.g. `cacerts` file for Linux distro builds of OpenJDK packaged as RPMs), or more generally when they get updated out-of-band of the JDK build itself like the tzupdater tool.
>>
>> When that happens the hash sum recorded at JDK build time of those files no longer match, causing `jlink` to fail. I propose to allow for those files to get "upgraded" should this happen. The way this works is as follows:
>>
>> 1. The list of upgradeable files is configured by a resource file in `jdk.jlink` on a per module basis. Right now, only two files from the `java.base` module will be allowed to be upgraded with a link from the current run-time image.
>> 2. For those files the hash sum checks are skipped.
>>
>> **Testing**
>>
>> - [x] GHA
>> - [x] `jdk/tools/jlink` jtreg tests
>> - [x] Some manual tests with updated `tzdb.dat` and `cacerts` files.
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments from Christoph
test/jdk/tools/jlink/runtimeImage/UpgradeableFileCacertsTest.java line 42:
> 40: /*
> 41: * @test
> 42: * @summary Verify that no errors are reported for files the have been
Suggestion:
* @summary Verify that no errors are reported for files that have been
😉
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24388#discussion_r2031112907
More information about the core-libs-dev
mailing list