RFR: 8352971: Increase maximum number of hold counts for ReentrantReadWriteLock [v2]
Alan Bateman
alanb at openjdk.org
Mon Apr 7 14:09:59 UTC 2025
On Mon, 7 Apr 2025 13:55:27 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> I'm breaking this change out as a separate improvement, since it will not be generally possible to adjust these limits on the j.u.c primitives since they might already use a backing `long` to pack in information which needs to be updated atomically (would require 128-bit atomics to widen them, and it still infeasible to change return types of pre-existing APIs).
>
> Viktor Klang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Make sure that the test fails in case of an InterruptedException
> - Adding support for more than 65k readers and writers of ReentrantReadWriteLock
Marked as reviewed by alanb (Reviewer).
test/jdk/java/util/concurrent/tck/ReentrantReadWriteLock20Test.java line 93:
> 91: while ((next = threads.pollFirst()) != null) {
> 92: while (next.isAlive()) {
> 93: next.join();
You can drop the inner-while as join will wait for the thread to terminate, no-op if already terminated.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24261#pullrequestreview-2746959737
PR Review Comment: https://git.openjdk.org/jdk/pull/24261#discussion_r2031322960
More information about the core-libs-dev
mailing list