RFR: 8353786: Migrate Vector API math library support to FFM API [v3]
Vladimir Ivanov
vlivanov at openjdk.org
Mon Apr 7 23:25:27 UTC 2025
On Mon, 7 Apr 2025 06:44:16 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> features_string -> cpu_info_string
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 258:
>
>> 256: if (LIBRARY.isSupported(op, vspecies)) {
>> 257: String symbol = LIBRARY.symbolName(op, vspecies);
>> 258: MemorySegment addr = LOOKUP.find(symbol)
>
> It is better to use `LOOKUP.findOrThrow()` because it does not require lambda creation.
Thanks, changed as you suggested. I introduced a try-catch block instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2032138430
More information about the core-libs-dev
mailing list