RFR: 8348556: Inlining fails earlier for MemorySegment::reinterpret [v6]
Per Minborg
pminborg at openjdk.org
Tue Apr 8 11:33:54 UTC 2025
> This PR proposes to add some `@ForceInline` annotations in the `Module` class in order to assist inlining of FFM var/method handles.
>
> There are also some changes in other classes (notably `j.l.Object`) which, if implemented, can take us four additional levels of inlining. However, there is a tradeoff with adding `@ForceInline` and just trying to get as deep as possible for a specific use case is probably not the best idea.
>
> So, we should discuss which of the proposed changes (if any), we'd like to integrate.
>
> Tested and passed tier1-3
Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
- Revert copyright year
- Revert changes to Object
- Merge branch 'master' into module-force-inline
- Add more @ForceInline and a benchmark
- Remove reformatting
- Remove file
- Revert change
- Rename method and variable
- Add @ForceInline annotations and restructure some methods
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23460/files
- new: https://git.openjdk.org/jdk/pull/23460/files/7a2f7f89..401d9d4f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23460&range=05
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23460&range=04-05
Stats: 212749 lines in 4960 files changed: 98853 ins; 86637 del; 27259 mod
Patch: https://git.openjdk.org/jdk/pull/23460.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23460/head:pull/23460
PR: https://git.openjdk.org/jdk/pull/23460
More information about the core-libs-dev
mailing list