RFR: 8354121: Use an anonymous class rather than a lambda in AbstractMemorySegmentImpl::cleanupAction [v3]
Chen Liang
liach at openjdk.org
Wed Apr 9 13:37:31 UTC 2025
On Wed, 9 Apr 2025 13:02:08 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to use an anonymous class rather than a lambda in order to improve startup time.
>>
>> We need to make sure the regression is fixed by this. It might be the case that the regression is there because [JDK-8347047](https://bugs.openjdk.org/browse/JDK-8347047) actually fixed an issue so that the segments could be collected by the GC.
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Use a record instead of anno class
> - Merge branch 'master' into ms-reinterpret-remove-lambda
> - Add comment on anonymous class
> - Replace lambda with anonymous class
Thanks for this error-proof improvement. Remember to update the JBS issue and PR titles.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24514#pullrequestreview-2753513351
More information about the core-libs-dev
mailing list