RFR: 8342486: Implement JEP 505: Structured Concurrency (Fifth Preview) [v8]
Alan Bateman
alanb at openjdk.org
Wed Apr 16 06:12:44 UTC 2025
On Tue, 15 Apr 2025 21:45:10 GMT, Viktor Klang <vklang at openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Add JEP number, update copyright headers
>> - Merge branch 'master' into JDK-8342486
>> - Sync up from loom repo
>> - Merge branch 'master' into JDK-8342486
>> - Sync up from loom repo
>> - Merge branch 'master' into JDK-8342486
>> - Merge branch 'master' into JDK-8342486
>> - Fix link
>> - Merge branch 'master' into JDK-8342486
>> - Sync up impl/tests form loom repo
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/3090e218...418bc3d3
>
> test/jdk/java/util/concurrent/StructuredTaskScope/StructuredTaskScopeTest.java line 977:
>
>> 975: scope.fork(() -> "foo");
>> 976: while (!scope.isCancelled()) {
>> 977: Thread.sleep(10);
>
> Might make sense to create a utility method to "awaitAndAssertCancel" since this location has a 10ms sleep but others have a 20ms sleep. (To ensure that it is handled uniformly)
That's a good suggestion, an awaitCancelled would avoid having this while loop in a number of tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21934#discussion_r2046150243
More information about the core-libs-dev
mailing list