RFR: 8354084: Streamline XPath API's extension function control [v3]
Roger Riggs
rriggs at openjdk.org
Wed Apr 16 13:49:38 UTC 2025
On Mon, 14 Apr 2025 21:00:22 GMT, Joe Wang <joehw at openjdk.org> wrote:
>> Streamline the extension function control in the XPath API by relying solely on [XPathFunctionResolver](https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/xpath/XPathFunctionResolver.html), which provides a secure and developer-defined mechanism. Remove the feature FEATURE_SECURE_PROCESSING and jdk.xml.enableExtensionFunctions from the decision path that are redundant with regard to XPath's Extension Functions.
>>
>> Note the comment in JAXPExtensionsProvider, starting at "JAXP 1.3 spec says When ...", was not accurate. Refer to the spec: https://docs.oracle.com/en/java/javase/24/docs/api/java.xml/javax/xml/XMLConstants.html#FEATURE_SECURE_PROCESSING, FSP does not have specific requirement for the XPath functions.
>>
>> Tests:
>> Tier1 - 3 passed with regard to this change. There were unrelated/known failures (e.g. bug8329757).
>> JCK passed except the previously reported issue (JCK-7322355).
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>
> rewind resource files, leave them to L10n resource files update
Changes requested by rriggs (Reviewer).
src/java.xml/share/classes/module-info.java line 883:
> 881: * <td style="text-align:center">
> 882: * <a href="#Transform">Transform</a><br>
> 883: * <a href="#XPATH">XPath</a>
The additional confirming text in the CSR is not present above.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24605#pullrequestreview-2772604102
PR Review Comment: https://git.openjdk.org/jdk/pull/24605#discussion_r2046981229
More information about the core-libs-dev
mailing list