RFR: 8341608: jdeps in JDK 23 crashes when parsing signatures while jdeps in JDK 22 works fine [v3]
Chen Liang
liach at openjdk.org
Mon Apr 21 16:06:26 UTC 2025
On Mon, 21 Apr 2025 15:44:20 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add a test
>
> test/langtools/tools/jdeps/MalformedClassesTest.java line 28:
>
>> 26: * @bug 8341608
>> 27: * @summary Tests for jdeps tool with jar files with malformed classes
>> 28: * @library lib /test/lib jdk.jdeps
>
> I am not too familiar with the `jdk.jdeps` style usage of `@library` here. Does the test still function without that `jdk.jdeps` entry? I briefly looked up the documentation of `@library` https://openjdk.org/jtreg/tag-spec.html#tags and it isn't clear to me what jtreg does with such a declaration.
Turns out this is not necessary when I have `@build jdk.jdeps/com.sun.tools.jdeps.*`. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24604#discussion_r2052655127
More information about the core-libs-dev
mailing list