RFR: 8354053: Remove unused JavaIOFilePermissionAccess [v2]
Weijun Wang
weijun at openjdk.org
Mon Apr 21 16:27:44 UTC 2025
On Mon, 14 Apr 2025 16:14:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and its implementation (FilePermCompat.java) used by the test is moved to java.io FilePermission where cross package access is not needed.
>> The test FilePermissionCollectionMerge is updated to access the internal implementation in FilePermission.
>> Modernized the initialization from the system property `jdk.io.permissionsUseCanonicalPath`.
>> The remaining support will be removed when FilePermission is removed.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify as suggested in review comments
> Convert static methods to instance methods and invoke on the existing FilePermission.
LGTM. In fact, there is no need to keep or test on `newPermPlusAltPath` and `newPermUsingAltPath`. Those were only used in access control checks with the "new" behavior.
-------------
Marked as reviewed by weijun (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24603#pullrequestreview-2781713842
More information about the core-libs-dev
mailing list