RFR: 8352003: Support --add-opens with -XX:+AOTClassLinking [v3]
Ioi Lam
iklam at openjdk.org
Mon Apr 21 18:46:41 UTC 2025
On Mon, 21 Apr 2025 06:20:46 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> This RFE allows --add-opens to be specified for AOT cache creation. AOT cache can be used during production run with --add-opens option as long as the same set of options is used during assembly phase.
>>
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>
> @iklam comment
test/hotspot/jtreg/runtime/cds/appcds/jigsaw/modulepath/AddOpens.java line 109:
> 107: "--add-opens", addOpensArg,
> 108: "--module-path", moduleDir.toString(),
> 109: "-m", TEST_MODULE1, "with_add_opens")
Could you add a test case for `=ALL-UNNAMED` as well? That is frequently used by applications, and it takes a different code path inside the implementation.
I think this can be done by running `com.simple.Main` in the classpath rather than module path.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24695#discussion_r2052848888
More information about the core-libs-dev
mailing list