RFR: 8354343: Hardening of Currency tests for not yet defined future ISO 4217 currency [v2]

Mon Apr 21 23:15:56 UTC 2025

On Mon, 21 Apr 2025 22:25:14 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move future currencies set up under setUpTestingData()
>
> test/jdk/java/util/Currency/ValidateISO4217.java line 183:
> 
>> 181:         setUpPatchedClasses();
>> 182:         setUpTestingData();
>> 183:         setUpNotYetDefined();
> 
> It may be clearer to move this inside `setUpTestingData()`, and modify the comment there

Right, makes more sense that way. Also updated the JBS issues as you requested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24782#discussion_r2053093655