RFR: 8354990: Improve negative tests coverage for jpackage signing [v2]

[Alexey Semenyuk]

On Mon, 21 Apr 2025 23:02:33 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix compilation error
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 691:
> 
>> 689:         }
>> 690: 
>> 691:         public String value( ) {
> 
> Extra space between `()`.

Fixed

> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 705:
> 
>> 703:     }
>> 704: 
>> 705:     public record CertificateRequest(String name, CertificateType type, int days, boolean expired, boolean trusted) implements Comparable<CertificateRequest>{
> 
> Space before `{`.

Fixed

> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 733:
> 
>> 731:             } else if (expired) {
>> 732:                 return VerifyStatus.VERIFY_EXPIRED;
>> 733:             }else {
> 
> Formating.

Fixed

> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacSign.java line 823:
> 
>> 821:     }
>> 822: 
>> 823:     private record InstalledCertificate(String name, CertificateType type, int days, boolean expired) implements Comparable<InstalledCertificate>{
> 
> Space before `{`.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24762#discussion_r2053134171
PR Review Comment: https://git.openjdk.org/jdk/pull/24762#discussion_r2053134256
PR Review Comment: https://git.openjdk.org/jdk/pull/24762#discussion_r2053134094
PR Review Comment: https://git.openjdk.org/jdk/pull/24762#discussion_r2053134012