RFR: 8354990: Improve negative tests coverage for jpackage signing [v3]

Alexander Matveev almatvee at openjdk.org
Tue Apr 22 00:18:46 UTC 2025


On Tue, 22 Apr 2025 00:14:17 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Add tests for the following test cases:
>>  - Expired certificate specified for signing;
>>  - Multiple certificates with the same name in one keychain.
>> 
>> Adding the new tests revealed an issue with MacCertificate - [JDK-8354989](https://bugs.openjdk.org/browse/JDK-8354989). This issue is also addressed in this PR.
>> 
>> Additionally:
>>  - Moved code to verify signatures in MacSignVerify class and reworked SigningBase verify functions to use MacSignVerify API.
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix formatting
>  - Fix formatting

Marked as reviewed by almatvee (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24762#pullrequestreview-2782457307


More information about the core-libs-dev mailing list