RFR: 8354724: BufferedReader readAllLines and readString methods [v8]

Alan Bateman alanb at openjdk.org
Tue Apr 22 10:19:45 UTC 2025


On Mon, 21 Apr 2025 20:47:38 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8354724: Change "lines" to "characters" in spec of Reader.readAllChars, where appropriate

src/java.base/share/classes/java/io/Reader.java line 401:

> 399:      * Reads all remaining characters into a string.
> 400:      *
> 401:      * <p> This method reads all content including the line separators in

Again, just to say that it's all remaining rather than "all content" as some characters may have been consumed before this method is invoked.

Now that you have readAllChars, I think it would be good to prototype a readAllLines (or better name) on Reader too. Consuming all characters means that Reader should not need to take on the characteristics of a buffered-Reader.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2053810987


More information about the core-libs-dev mailing list