RFR: 8354450: Using a File with a path containing a trailing space should fail when alternative data streams are disabled (win) [v3]

[Alan Bateman]

On Fri, 18 Apr 2025 18:44:58 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In `java.io.WinNTFileSystem::isInvalid`, replace an insufficient test for file path validity with a sufficient test for file path invalidity. Also, add a new test.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8354450: Account for spaces in directory elements; update test

src/java.base/windows/classes/java/io/WinNTFileSystem.java line 376:

> 374:                 return true;
> 375:             theFile = theFile.getParentFile();
> 376:         } while (theFile != null);

The input has already been normalized so I think you can reduce it down to searching getPath for a trailing space or a backslash followed by a space.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24635#discussion_r2054409320