RFR: 8354343: Hardening of Currency tests for not yet defined future ISO 4217 currency [v2]
Naoto Sato
naoto at openjdk.org
Tue Apr 22 16:49:50 UTC 2025
On Mon, 21 Apr 2025 23:15:56 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which improves future currency checking for ISO 4217 currencies.
>>
>> Checking for a currency that should not yet exist in the set of available currencies is already done.
>> It should also be explicitly checked that such a currency can not be instantiated as well via the String getter.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> move future currencies set up under setUpTestingData()
Marked as reviewed by naoto (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24782#pullrequestreview-2784722422
More information about the core-libs-dev
mailing list