RFR: 8350703: Add standard system property stdin.encoding
Alan Bateman
alanb at openjdk.org
Wed Apr 23 12:58:44 UTC 2025
On Wed, 23 Apr 2025 01:33:39 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> * Windows and Unix: set sprops.stdin_encoding if connected to a console
>> * Add specs for stdin.encoding
>> * Adjust specs to change "undefined" to "unspecified"
>> * Rewrite System.in spec to refer to new property and to clarify usage with classes that perform encoding
>> * Update property test
>
> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 92:
>
>> 90:
>> 91: // Encoding properties for stdin, stdout, and stderr. For stdout and stderr,
>> 92: // check "sun.*.encoding" properties before falling back to the
>
> Could explain about sun* a bit more (just for compatibility) and stdin.encoding is free from it.
I think the comment could be clearer. As I understand it, it's just trying to saying that the legacy sun.stdout.encoding/sun.stderr.encoding properties for stdout/stderr only, no equivalent for stdin.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24738#discussion_r2055991997
More information about the core-libs-dev
mailing list