Integrated: 8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test
Jaikiran Pai
jpai at openjdk.org
Wed Apr 23 14:26:57 UTC 2025
On Tue, 22 Apr 2025 09:05:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this test only change which proposes to improve the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`?
>
> This test has been failing intermittently in our CI for several years. Detailed are noted in https://bugs.openjdk.org/browse/JDK-8287062. Most of these failures are because the exception message, in an exception that was raised, contains an unexpected value (apparently `null`). The test doesn't propagate the unexpected exception, thus it's not clear why the exception message is different than what the test expects. The commit in this PR propagates the original exception if the message is unexpected. This should help identify the underlying cause of the test failure, if/when it fails the next time.
>
> I have run this test with these changes and the test continues to pass.
This pull request has now been integrated.
Changeset: 6befc189
Author: Jaikiran Pai <jpai at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6befc189741069cc4b188e4822541fb9ab72ee28
Stats: 34 lines in 1 file changed: 14 ins; 9 del; 11 mod
8355278: Improve debuggability of com/sun/jndi/ldap/LdapPoolTimeoutTest.java test
Reviewed-by: aefimov
-------------
PR: https://git.openjdk.org/jdk/pull/24793
More information about the core-libs-dev
mailing list