RFR: 8354724: BufferedReader readAllLines and readString methods [v13]
Johannes Graham
duke at openjdk.org
Wed Apr 23 18:08:49 UTC 2025
On Wed, 23 Apr 2025 16:52:29 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8354724: Improve test per reviewer comments
src/java.base/share/classes/java/io/Reader.java line 212:
> 210:
> 211: public String readAllChars() throws IOException {
> 212: return cs.toString();
Should this be returning a substring of `cs` starting at `next`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2056635722
More information about the core-libs-dev
mailing list